Re: [PATCH 2/9] omap: mux: Add new style pin multiplexing code for omap3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Cousson, Benoit <b-cousson@xxxxxx> [100827 02:17]:
> On 8/27/2010 4:29 AM, rockefeller wrote:
> >
> >Because "muxname.mode7" in in RAM is modifiable, after function call
> >to function1(), the *pine_mux_name will be "muxname" and therefore when
> >calls to function2() to try to set this pin in mode7 with value 0x0000
> >might be un-expected result.
> 
> In theory the pin mux is done once at init time, so I'm not sure
> this case is supposed to happen. Is it a real case?
> 
> Anyway, I think that a simple strlcpy(tmp, muxname, 32) in
> omap_mux_init_signal can fix it.
> 
> Do you mind submitting a patch to fix that?

Yeah that's a bug, we should not trash the muxname.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux