> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, August 27, 2010 4:34 AM > To: Varadarajan, Charulatha > Cc: linux-omap@xxxxxxxxxxxxxxx; wim@xxxxxxxxx; paul@xxxxxxxxx; Cousson, > Benoit; Nayak, Rajendra; Basak, Partha > Subject: Re: [PATCH 5/5 v3] OMAP2PLUS: WDT: Conversion to runtime PM > > Charulatha V <charu@xxxxxx> writes: > > > This patch converts the OMAP Watchdog timer driver to > > get adapted to HWMOD FW and to use the runtime PM APIs. > > Technically, the driver knows nothing about the HWMOD framework, as > that's an OMAP core implementation detail. > > What's really happening here is two separate things: > > 1) conversion of driver to runtime PM instead of clock framework > 2) convert platform_device/_data over to be omap_device-based > > These should be done in two separate patches (and in that order.) Okay. > > Other than that, the patch contents look good. Some minor comments > below... > > > Signed-off-by: Charulatha V <charu@xxxxxx> > > Signed-off-by: Basak, Partha <p-basak2@xxxxxx> > > --- > > arch/arm/plat-omap/devices.c | 64 ++++++++++++++++++++++++++++------- > ------ > > drivers/watchdog/omap_wdt.c | 43 +++++----------------------- > > 2 files changed, 52 insertions(+), 55 deletions(-) > > > > [...] > > > diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c > > index 76b58ab..7645ca3 100644 > > --- a/drivers/watchdog/omap_wdt.c > > +++ b/drivers/watchdog/omap_wdt.c > > @@ -38,13 +38,14 @@ > > #include <linux/err.h> > > #include <linux/platform_device.h> > > #include <linux/moduleparam.h> > > -#include <linux/clk.h> > > #include <linux/bitops.h> > > #include <linux/io.h> > > #include <linux/uaccess.h> > > #include <linux/slab.h> > > +#include <linux/pm_runtime.h> > > #include <mach/hardware.h> > > #include <plat/prcm.h> > > +#include <plat/omap_device.h> > > This should not be needed in the driver, as there is no need for driver > to call omap_device API. > Yes, I will not include it. > [...] > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
