Re: [PATCH 10/20] Move rfbi init to rfbi probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Guruswamy Senthilvadivu <svadivu@xxxxxx> writes:

> From: Senthilvadivu Guruswamy <svadivu@xxxxxx>
>
> RFBI init and exit moved to rfbi probe and remove.
>
> Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>

[...]

> @@ -357,11 +348,21 @@ static int omap_dsi1hw_remove(struct platform_device *pdev)
>  /* RFBI HW IP initialisation */
>  static int omap_rfbihw_probe(struct platform_device *pdev)
>  {
> -	return 0;
> +	int r;

minor: missing blank line

> +	dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK1 | DSS_CLK_54M);
> +	r = rfbi_init();
> +	if (r) {
> +		DSSERR("Failed to initialize rfbi\n");
> +		goto err_rfbi;
> +	}

here too

> +err_rfbi:
> +	dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1 | DSS_CLK_54M);
> +	return r;
>  }
>  
>  static int omap_rfbihw_remove(struct platform_device *pdev)
>  {
> +	rfbi_exit();
>  	return 0;
>  }

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux