On Mon, 2010-08-23 at 17:57 +0200, ext Guruswamy Senthilvadivu wrote: > From: Senthilvadivu Guruswamy <svadivu@xxxxxx> > > dsshw_probe and remove functions are moved to dss.c > To maintain the order of init, through the dsshw_probe, omap_dss_init2 > is made as device_init_call_sync. > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx> Why is the omap_dsshw_driver moved to dss.c, but the hw_driver for other blocks stay in core.c? And generally about dss.c: There are confusingly two things DSS may refer to: 1) the whole display subsystem, including DSI/RFBI etc 2) the small main block inside DSS, meaning the few DSS_* registers. It would be good to have different names for those, but at the time being they are both "DSS". In some patch I saw names like "dss_dispc". Perhaps we could have "dss_dss" there too. Although it looks a bit confusing too =). dss.c is meant to handle the DSS_* registers, so it's about case 2. And so it doesn't contain general DSS stuff, like clock allocation etc., those have been in core.c. I'm not sure if this comment is valid for this patch, but at least "[PATCH 07/20] Move clock functions from core driver to dss driver" sounds like dss.c is used like case 1. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
