On Mon, 2010-08-23 at 10:51 +0200, ext Mike Rapoport wrote:
> Tomi Valkeinen wrote:
> > On Mon, 2010-08-23 at 09:19 +0200, ext Mike Rapoport wrote:
> >> Tomi Valkeinen wrote:
> >>> I tested 36-rc1 briefly with OMAP 3430SDP board. I wonder why that
> >>> works, but not N900...
> >> May it be that 3430SDP uses SRAM for the framebuffer? Or reserves framebuffer
> >> memory from the RAM that is not managed by the kernel, e.g with something like
> >> mem=<RAM size - fb size> vram=<fb size>,0x8...... ?
> >
> > No, SRAM cannot be used on OMAP3s, as SRAM is too small to hold a
> > framebuffer. And no, I don't think it's reserving it from RAM not
> > managed by the kernel.
>
> The N900 only sets omap_vram_sdram_{start,size} in rx51_video_mem_init.
> I think that it should also call omap_vram_reserve_sdram_memblock():
>
> diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
> index 5a1005b..fdfe844 100644
> --- a/arch/arm/mach-omap2/board-rx51-video.c
> +++ b/arch/arm/mach-omap2/board-rx51-video.c
> @@ -101,6 +101,7 @@ void __init rx51_video_mem_init(void)
> */
> omap_vram_set_sdram_vram(PAGE_ALIGN(864 * 480 * 4) +
> 2 * PAGE_ALIGN(1280 * 720 * 4 * 2), 0);
> + omap_vram_reserve_sdram_memblock();
> }
But omap_vram_reserve_sdram_memblock() is called automatically from
arch/arm/plat-omap/common.c. rx51_video_mem_init() should have been
called before that happens. Has the call order changed, so that
omap_vram_reserve_sdram_memblock() is called first, and
rx51_video_mem_init() only after that?
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
