Hi Felipe, > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > Sent: Tuesday, August 24, 2010 1:49 PM > To: C.A, Subramaniam > Cc: linux-omap@xxxxxxxxxxxxxxx; Gadiyar, Anand; tony@xxxxxxxxxxx > Subject: Re: [PATCH]omap: i2c: Avoid compilation error in > case the header is included multiple times > > On Tue, Aug 24, 2010 at 07:14:30PM +0200, ext C.A, Subramaniam wrote: > >>From e3c3ee9317850b2b26e02680a0c976d3c75febab Mon Sep 17 > 00:00:00 2001 > >From: Subramaniam C.A <subramaniam.ca@xxxxxx> > >Date: Tue, 24 Aug 2010 12:02:28 -0500 > >Subject: [PATCH] omap: i2c: Avoid compilation error in case > the header is included multiple times. > > > >Added defines to avoid compilation error. > > > > could you list one such case ? This caused a compilation error for the OMAP4 tree, where the ipu_pm.c file was including plat/i2c.h and plat/omap-pm.h. Ref: http://dev.omapzoom.org/?p=integration/kernel-omap4.git;a=blob;f=drivers/dsp/syslink/ipu_pm/ipu_pm.c;h=b1791d4e7f2113eed046d3785106360dbe1cfc86;hb=d67c37aaadb80a6209f07618302bb84e1c952e97 omap-pm.h indirectly includes plat/i2c.h and hence the compilation error. Yes we could have removed the, #include <plat/i2c.h> from the ipu_pm.c file and avoided the compilation error, but it still made sense to have this patch. > > >Signed-off-by: Subramaniam C.A <subramaniam.ca@xxxxxx> > > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > -- > balbi > > DefectiveByDesign.org > BR Subbu-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
