> +static int omap_prox_activate(struct device *dev) No tab needed before the function name - a space will do. (at least for consistency with other functions in the file). I don't know if this is serious enough to warrant a new revision, but if you're reworking this patch for something else, please fix this as well. > +{ > + gpio_set_value(OMAP4_SFH7741_ENABLE_GPIO , 1); > + return 0; > +} > + - Anand-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html