Felipe Balbi wrote: > >> >@@ -126,6 +126,14 @@ config USB_EHCI_MXC > >> > ---help--- > >> > Variation of ARC USB block used in some Freescale chips. > >> > > >> >+config USB_EHCI_HCD_OMAP3 > >> >+ bool "EHCI support for OMAP3 and later chips" > >> >+ depends on USB_EHCI_HCD && (ARCH_OMAP3 || ARCH_OMAP4) > >> > >> this line doesn't scale. When we have another omap release this will > >> become e.g. ARCH_OMAP3 || ARCH_OMAP4 || ARCH_OMAP5 || ARCH_OMAP6 etc > >> etc, so instead of depending on ARCH_OMAPX, depend only on ARCH_OMAP and > >> make the architecture select the USB_ARCH_HAS_EHCI like this: > > > >ARCH_OMAP includes OMAP1/2, and these chips do not have any EHCI controllers. > > > >Is this okay? > > as long as noone selects USB_ARCH_HAS_EHCI for omap1/2 it's fine. > We have the ability to support OMAP2 and OMAP3 in the same kernel image (for example when you build with omap3_defconfig). So USB_ARCH_HAS_EHCI will get selected due to OMAP3 being present. However, no platform devices will be registered in the OMAP2 board files, so this should be okay (will try this on OMAP2 to check). - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
