On Thu, Aug 19, 2010 at 1:53 AM, Jarkko Nikula <jhnikula@xxxxxxxxx> wrote: > On Wed, 18 Aug 2010 10:56:51 -0500 > Robert Nelson <robertcnelson@xxxxxxxxx> wrote: > >> + ret = gpio_request(171, "rev_id_0"); >> + if (ret < 0) >> + goto fail0; >> + >> + ret = gpio_request(172, "rev_id_1"); >> + if (ret < 0) >> + goto fail1; >> + >> + ret = gpio_request(173, "rev_id_2"); >> + if (ret < 0) >> + goto fail2; > ... >> +fail2: >> + gpio_free(173); >> +fail1: >> + gpio_free(172); >> +fail0: >> + gpio_free(171); > > This must be: > > +fail2: > + gpio_free(172); > +fail1: > + gpio_free(171); > +fail0: > > Otherwise the set looks good to me. > > > -- > Jarkko > Thanks Jarkko, Yeah that one is obvious, will resubmit.. Regards, -- Robert Nelson http://www.rcn-ee.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
