Hi,
>-----Original Message-----
>From: Cousson, Benoit
>Sent: Monday, August 09, 2010 5:22 PM
>To: Kalliguddi, Hema
>Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx;
>Felipe Balbi; Tony Lindgren; Kevin Hilman
>Subject: Re: [PATCH 4/8]usb: musb: HWMOD database structures
>fixes OMAP4
>
>Hi Hema,
>
>On 8/6/2010 5:57 PM, Kalliguddi, Hema wrote:
>> From: Hema HK<hemahk@xxxxxx>
>>
>> Fixed the missing sysc settings for OMAP4 and enabled the OMAP4
>> hwmod data structure.
>>
>> Signed-off-by: Hema HK<hemahk@xxxxxx>
>> Cc: Felipe Balbi<felipe.balbi@xxxxxxxxx>
>> Cc: Tony Lindgren<tony@xxxxxxxxxxx>
>> Cc: Kevin Hilman<khilman@xxxxxxxxxxxxxxxxxxx>
>
>It is a good practice, if not mandatory, to CC the authors of the file
>you are modifying with your patch.
>Neither Paul, nor myself are in CC of this patch. Could you please add
>us to this one and the other ones when applicable?
It is mistake of not CCing the owner. I will take care of it.
>
>> ---
>>
>> Index: linux-omap-pm/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> ===================================================================
>> ---
>linux-omap-pm.orig/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>2010-08-06 08:31:45.885868560 -0400
>> +++ linux-omap-pm/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>2010-08-06 08:35:41.250112281 -0400
>> @@ -4516,8 +4516,15 @@
>> */
>>
>> static struct omap_hwmod_class_sysconfig
>omap44xx_usb_otg_hs_sysc = {
>> - .sysc_flags = SYSS_MISSING,
>> - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
>> +
>> + .rev_offs = 0x0400,
>> + .sysc_offs = 0x0404,
>> + .syss_offs = 0x0408,
>> + .sysc_flags = SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE|
>> + SYSC_HAS_ENAWAKEUP | SYSC_HAS_SOFTRESET |
>> + SYSC_HAS_AUTOIDLE,
>> + .idlemodes = SIDLE_FORCE | SIDLE_NO | SIDLE_SMART,
>> + .sysc_fields =&omap_hwmod_sysc_type1,
>> };
>
>This part if fine except the missing MIDLE_XXX modes. Here is the
>modified version using the same convention as other modules:
OK. I will add it.
>
> > static struct omap_hwmod_class_sysconfig
>omap44xx_usb_otg_hs_sysc = {
> > - .sysc_flags = SYSS_MISSING,
> > - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
> > + .rev_offs = 0x0400,
> > + .sysc_offs = 0x0404,
> > + .syss_offs = 0x0408,
> > + .sysc_flags = (SYSC_HAS_AUTOIDLE | SYSC_HAS_ENAWAKEUP |
> > + SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE |
> > + SYSC_HAS_SOFTRESET),
> > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> > + MSTANDBY_FORCE | MSTANDBY_NO |
>MSTANDBY_SMART),
> > + .sysc_fields = &omap_hwmod_sysc_type1,
> > };
>
>I don't have any preference for the parens, but in order to be
>consistent with the already existing hwmods, let's keep them.
There was comment from Sergie to remove the parens for omap3 database. So I have removed.
>
>Regards,
>Benoit
>--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
