Charulatha V <charu@xxxxxx> writes:
> @@ -650,21 +511,28 @@ static void _set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
> __raw_writel(debounce, reg);
>
> reg = bank->base;
> - if (cpu_is_omap44xx())
> + if (bank->method == METHOD_GPIO_44XX)
> reg += OMAP4_GPIO_DEBOUNCENABLE;
> else
> reg += OMAP24XX_GPIO_DEBOUNCE_EN;
>
> val = __raw_readl(reg);
>
> + if (!bank->dbck) {
> + struct platform_device *pdev = to_platform_device(bank->dev);
> + struct omap_device *odev = to_omap_device(pdev);
insert empty line
> + if (odev->hwmods[0]->opt_clks->_clk)
> + bank->dbck = odev->hwmods[0]->opt_clks->_clk;
As was discussed in Bangalore, drivers should have no knowledge of hwmod
internals.
Instead, please propose an API to hwmod for getting the optional
clock(s), or possibly cleaner, an API to directly enable/disable
optional clocks for an omap_device.
Kevin
> + if (IS_ERR(bank->dbck))
> + dev_err(bank->dev, "Could not get gpio dbck\n");
> + }
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
