> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Tuesday, August 03, 2010 5:32 PM > To: ext Grazvydas Ignotas > Cc: linux-fbdev@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Hiremath, > Vaibhav > Subject: Re: [PATCH] OMAP: DSS2: OMAPFB: add support for FBIO_WAITFORVSYNC > > On Fri, 2010-07-02 at 22:54 +0200, ext Grazvydas Ignotas wrote: > > FBIO_WAITFORVSYNC is a stardard ioctl for waiting vsync, already > > used by some userspace, so add it as an alias for OMAPFB_WAITFORVSYNC. > > > > Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> > > --- > > Tomi, > > > > I know I already sent this earlier, but as now FBIO_WAITFORVSYNC is a > > standard ioctl, so why don't we support it? I know you might not like > > that omapfb_ioctl will have one standard ioctl handler between all OMAP > > specific ones, but that's something plenty of other drivers do. > > One could ask that if FBIO_WAITFORSYNC is a standard ioctl, why do we > need to handle it in omapfb's custom ioctl function =). > > But I think this is fine, I'll apply. [Hiremath, Vaibhav] I still think we should mark the old (custom) interface as deprecated and add new standard ioctl interface here, so that in the future we can remove custom one. Thanks, Vaibhav > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
