Re: [PATCH 1/3] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONACHED L1 entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 08, 2010 at 03:47:52PM +0530, Santosh Shilimkar wrote:
> @@ -475,6 +486,9 @@ static void __init build_mem_type_table(void)
>  	mem_types[MT_LOW_VECTORS].prot_l1 |= ecc_mask;
>  	mem_types[MT_HIGH_VECTORS].prot_l1 |= ecc_mask;
>  	mem_types[MT_MEMORY].prot_sect |= ecc_mask | cp->pmd;
> +	mem_types[MT_MEMORY].prot_pte |= kern_pgprot;
> +	mem_types[MT_MEMORY_NONCACHED].prot_sect |= ecc_mask | cp->pmd;
> +	mem_types[MT_MEMORY_NONCACHED].prot_pte |= kern_pgprot;

This is wrong - it will result in the non-cached memory mapped in as
sections having the same cache settings as MT_MEMORY - in other
words, probably write back.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux