Kevin Hilman wrote: > Hemant Pedanekar <hemantp@xxxxxx> writes: > >> This patch updates the common machine spcific source files with support >> for TI816X. >> >> Note that the nr_irqs is overridden in INTC driver since the number of >> IRQs on TI816X are different (128) comapared to other OMAPs (96). >> >> Signed-off-by: Hemant Pedanekar <hemantp@xxxxxx> > > One minor issue below... > > [...] > >> @@ -899,10 +899,10 @@ void omap2_clkdm_allow_idle(struct clockdomain >> *clkdm) >> >> /* >> * XXX This should be removed once TI adds wakeup/sleep >> - * dependency code and data for OMAP4. >> + * dependency code and data for OMAP4, TI816X >> */ >> - if (cpu_is_omap44xx()) { >> - WARN_ONCE(1, "clockdomain: OMAP4 wakeup/sleep dependency " >> + if (cpu_is_omap44xx() || cpu_is_ti816x()) { >> + WARN_ONCE(1, "clockdomain: wakeup/sleep dependency " >> "support is not yet implemented\n"); >> } else { >> if (atomic_read(&clkdm->usecount) > 0) >> @@ -941,9 +941,9 @@ void omap2_clkdm_deny_idle(struct clockdomain *clkdm) >> >> /* >> * XXX This should be removed once TI adds wakeup/sleep >> - * dependency code and data for OMAP4. >> + * dependency code and data for OMAP4, TI816X. >> */ >> - if (cpu_is_omap44xx()) { >> + if (cpu_is_omap44xx() || cpu_is_ti816x()) { >> WARN_ONCE(1, "clockdomain: OMAP4 wakeup/sleep dependency " > > Did you want to remove the 'OMAP4' here as you did in the hunk above? > > Kevin Yes, I will fix that in v2. Thanks - Hemant -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html