Kevin, > -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, August 04, 2010 3:27 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; Cousson, Benoit; Paul > Walmsley; Tony Lindgren; Sawant, Anand; Shilimkar, Santosh; > Nayak, Rajendra; Basak, Partha; Varadarajan, Charulatha > Subject: Re: [PATCH 04/11] OMAP3: DMA: HWMOD: Add hwmod data > structures > > Manjunatha GK <manjugk@xxxxxx> writes: > > > This patch adds OMAP3 DMA hwmod structures. > > > > Signed-off-by: Manjunatha GK <manjugk@xxxxxx> > > [...] > > > +static struct omap_hwmod omap3xxx_dma_system_hwmod = { > > + .name = "dma", > > + .class = &omap3xxx_dma_hwmod_class, > > + .mpu_irqs = omap3xxx_dma_system_irqs, > > + .mpu_irqs_cnt = ARRAY_SIZE(omap3xxx_dma_system_irqs), > > + .main_clk = "l3_div_ck", > > + .prcm = { > > + .omap2 = { > > + /* .clkctrl_reg = NULL, */ > > + }, > > + }, > > Has this been tested? Without valid fields here the hwmod > will never be > enabled. This patch series has been tested on both omap3 and omap4. I didn't find any entries for DMA module in prcm-common.h(for assigning .module_bit etc) hence I commented this for clarification. However, all omap3 applicable dma tests used to pass with these changes. I can include and test it again if these entries are available at some other place or I can define if it is applicable for DMA. -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
