Hi Ohad, On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: > I'm honestly trying to understand your concerns, but I'm afraid that > just saying "it's a hack" is not too informative. Can you please > explain what do you think is technically wrong with the proposed > solution ? is it not general enough for other use cases ? will it > break something ? let's summarize the solution you're proposing. You're trying to add embedded_data which will be scattered all over the place. The patches you introduce do the following: - add the pointer to the mmc core header; - add the primitive to set it from the controller driver; - add the pointer to the board-specific header; - add the structure to the board-specific C file and propagate its pointer to the controller driver; - add setting the pointer in the core structure into the controller driver. So if I'd like to set the *same* structure for the *same* WL1271 driver, provided that I'm working with the other platform, I'll need to do the following: - add the pointer to the board-specific header; - add the structure to the board-specific C file and propagate its pointer to the controller driver; - add setting the pointer in the core structure into the controller driver. This is far from being intuitive. This means we need to hack, generally speaking, all the MMC controller drivers to get it working on all platforms. This is error prone. And I'm not even speaking about the fact that MMC controller driver should not deal with such things at all. Thanks, Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
