Re: [PATCH v2] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-08-02 at 15:14 +0200, ext archit taneja wrote:
> From: Archit Taneja <archit@xxxxxx>
> 
> The function overlay_manager_store currently fails if the sysfs input is a
> prefix string of an existing overlay manager name. This occurs because strncmp
> compares the two strings only till the length of the input sysfs string. So a
> sysfs input "lcd" will match manager name "lcd2" which is incorrect behavior.
> 
> The use of sysfs_streq here will prevent this false positive match to occur.
> 
> Signed-off-by: Archit Taneja <archit@xxxxxx>

Looks good, thanks!

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux