> -----Original Message----- > From: Taneja, Archit > Sent: Thursday, July 29, 2010 4:40 PM > To: Premi, Sanjeev; tomi.valkeinen@xxxxxxxxx > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH resend] OMAP: DSS2: Replace strncmp() > with sysfs_streq() in overlay_manager_store() > > > [snip] > > > > > > > [sp] This explains. And my earlier comment was to update the > > description with need for change. I believe quick summary > > the discussion above will be good for the patch. > > > > Okay, will do. But what am is supposed to add more in the summary? > Should I add how sysfs_streq is a better choice over strcmp? Or > should I emphasize more how the false positive scenario > can occur with strncmp? I believe it should indicate problem being fixed. sysfs_streq() vs strncmp() is means of arriving at solution. > > Thanks, > > Archit-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
