Agree! I'll send new version of this patch. >-----Original Message----- >From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] >Sent: Wednesday, July 28, 2010 12:12 PM >To: Ramos Falcon, Ernesto >Cc: Menon, Nishanth; gregkh@xxxxxxx; Ramirez Luna, Omar; ohad@xxxxxxxxxx; >ameya.palande@xxxxxxxxx; felipe.contreras@xxxxxxxxx; Guzman Lugo, Fernando; >linux-kernel@xxxxxxxxxxxxxxx; andy.shevchenko@xxxxxxxxx; linux- >omap@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 2/5] staging:ti dspbridge: remove unnecessary check for >NULL pointer in cmm.c > >Hi Ernesto, > >On Wed, Jul 28, 2010 at 7:53 PM, Ramos Falcon, Ernesto <ernesto@xxxxxx> >wrote: >>>here is a better approach: >>>remove cmm_xlator_delete altogether > >[...] > >> I considered this approach before but in terms of maintainability I >thought it was easier to locate where translator tables are destroy if we >keep cmm_xlator_delete function. > >That's not maintainability, that's debugging convenience. AFAIU linux >is all about maintenance, because that provides real, tangible, and >proven gains. Debugging convenience gains are hypothetical; you don't >really know how useful it will be to have a separate free function. > >And please avoid bottom-posting, instead use interleaved style, >otherwise people see a comment, and then have to scroll down to see >the answer. >http://en.wikipedia.org/wiki/Posting_style#Interleaved_style > >-- >Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
