Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hari,

On Wed, Jul 28, 2010 at 1:02 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> On Wed, Jul 21, 2010 at 12:41 AM, Hari Kanigeri <h-kanigeri2@xxxxxx> wrote:
> > This patch provides mutiple readers support for a mailbox
> > instance.
> >
> > Signed-off-by: Hari Kanigeri <h-kanigeri2@xxxxxx>
> > ---
> >  arch/arm/plat-omap/include/plat/mailbox.h |    6 ++-
> >  arch/arm/plat-omap/mailbox.c              |   63 ++++++++++++++++------------
> >  2 files changed, 40 insertions(+), 29 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/include/plat/mailbox.h b/arch/arm/plat-omap/include/plat/mailbox.h
> > index 0486d64..c8e47d8 100644
> > --- a/arch/arm/plat-omap/include/plat/mailbox.h
> > +++ b/arch/arm/plat-omap/include/plat/mailbox.h
> > @@ -68,13 +68,15 @@ struct omap_mbox {
> >        void                    *priv;
> >
> >        void                    (*err_notify)(void);
> > +       atomic_t                use_count;
> > +       struct blocking_notifier_head   notifier;
> >  };
> >
> >  int omap_mbox_msg_send(struct omap_mbox *, mbox_msg_t msg);
> >  void omap_mbox_init_seq(struct omap_mbox *);
> >
> > -struct omap_mbox *omap_mbox_get(const char *);
> > -void omap_mbox_put(struct omap_mbox *);
> > +struct omap_mbox *omap_mbox_get(const char *, struct notifier_block *nb);
>
> In this context, I'd like to change notifier to support adding a
> cookie which will be passed back to the handler function (unmodified,
> in a similar manner to request_irq's void *dev param).

This can be easily achieved with a simple container_of manipulation,
so please disregard my request : your patch is fine as-is. After it is
accepted, it'd be simple to add this context-get-back to dspbridge.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux