RE: [PATCH 12/20] OMAP: PM: create omap_devices for MPU, DSP, L3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thara,

On Sat, 24 Jul 2010, Gopinath, Thara wrote:

> >>>>+struct device *omap2_get_dsp_device(void)
> >>>>+{
> >>>>+	WARN_ON_ONCE(!dsp_dev);
> >>>>+	return dsp_dev;
> >>>>+}
> >>First of all, apologies for so late posting of the comment. IMHO it would be good to rename this API
> >>as omap2_get_iva_device. This is because OMAP4 has separate IVA and DSP devices and we will need to
> >>build the omap_device for both. If we could rename this as omap2_get_iva_device, we could introduce
> >>another API omap4_get_iva_device until bridge starts doing a omap_device_build for all these devices.
> 
> Hello Paul,
> 
> Any thoughts on this one?

Makes sense to me.  Probably we should queue a patch up to fix that for 
2.6.37...


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux