Gopinath, Thara had written, on 07/24/2010 01:42 AM, the following:
This patch adds the check for whether a omap_device and in turn
platform_device and device pointers exist for the device before
adding it's opp table into the global table. This is because all
the later accesses to the opp entries are based on dev pointer and
hence there is no point in adding a opp if the dev pointer does
not exist.
Signed-off-by: Thara Gopinath <thara@xxxxxx>
---
arch/arm/plat-omap/opp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
index 0273497..e81bb95 100644
--- a/arch/arm/plat-omap/opp.c
+++ b/arch/arm/plat-omap/opp.c
@@ -333,7 +333,7 @@ int opp_add(const struct omap_opp_def *opp_def)
return -EINVAL;
}
oh = omap_hwmod_lookup(opp_def->hwmod_name);
- if (!oh) {
+ if (!oh || !oh->od) {
pr_warn("%s: no hwmod for %s, cannot add OPPs.\n",
just to continue to have sane warnings,
minor nitpick -> s/no hwmod/no hwmod or odev/
__func__, opp_def->hwmod_name);
return -EINVAL;
Acked-by: Nishanth Menon <nm@xxxxxx>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
