Re: [PATCH] [ARM] omap/board-cm-t35: fix visual artefacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> CM-T35 DVI transmitter sampling the data on the raising edge of the
> pixel clock, therefore the data strobe should happen on the falling
> edge.
>
> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx>
> Signed-off-by: Mike Rapoport <mike@xxxxxxxxxxxxxx>
>   

NAK, this only fixes the pixel clock sampling on the second
call to the platform enable function, because the
dss configuration is done before the first call.

I will send another patch for this.
Sorry for misleading.

> ---
>  arch/arm/mach-omap2/board-cm-t35.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
> index e679a2c..015ebf8 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -349,6 +349,8 @@ static int cm_t35_panel_enable_dvi(struct omap_dss_device *dssdev)
>  		return -EINVAL;
>  	}
>  
> +	dssdev->panel.config |= OMAP_DSS_LCD_IPC | OMAP_DSS_LCD_ONOFF;
> +
>  	gpio_set_value(dvi_en_gpio, 0);
>  	dvi_enabled = 1;
>  
>   

-- 
Regards,
Igor.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux