Hi,
Just for the record, I found a problem in this patch. The next patch
in the series overrides it, so it's not that important, unless
somebody picks only this patch.
On Thu, May 27, 2010 at 7:02 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> @@ -537,23 +606,30 @@ dsp_status proc_enum_nodes(void *hprocessor, void **node_tab,
> }
>
> /* Cache operation against kernel address instead of users */
> -static int memory_sync_page(struct vm_area_struct *vma, unsigned long start,
> - ssize_t len, enum dsp_flushtype ftype)
> +static int memory_sync_page(struct dmm_map_object *map_obj,
> + unsigned long start, ssize_t len, enum dsp_flushtype ftype)
> {
> struct page *page;
> void *kaddr;
[...]
> - if (memory_sync_vma((u32) pmpu_addr, ul_size, FlushMemType)) {
> + /* find requested memory are in cached mapping information */
> + map_obj = find_containing_mapping(pr_ctxt, (u32) pmpu_addr, ul_size);
> + if (!map_obj) {
> + pr_err("%s: find_containing_mapping failed\n", __func__);
> + status = -EFAULT;
> + goto err_out;
> + }
> + if (memory_sync_page(map_obj, (u32) pmpu_addr, ul_size, ul_flags)) {
It should be FlushMemType, not ul_flags.
> pr_err("%s: InValid address parameters %p %x\n",
> - __func__, pmpu_addr, ul_size);
> + __func__, pmpu_addr, ul_size);
> status = -EFAULT;
> }
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
