RE: [PATCH resend v2] omap: 3630: disable TLL SAR on 3630 ES1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aguirre, Sergio wrote:
> > +/*
> > + * The USBTLL Save-and-Restore mechanism is broken on
> > + * 3430s upto ES3.0 and 3630ES1.0. Hence this feature
> > + * needs to be disabled on these chips.
> > + * Refer: 3430 errata ID i459 and 3630 errata ID i579
> > + */
> >  static struct powerdomain core_3xxx_pre_es3_1_pwrdm = {
> 
> IMHO, The above name (and below ones) should be revisited, since
> its becoming misleading (even before your patch).
> Pre ES3.1 on OMAP3 chips is confusing, since both 3630ES1.0 and
> ES1.1 _are_ "pre ES3.1".
> 
> Not sure if this needs to be taken care before or in this patch..
> 
> What do you think? 

I thought of this, but did not want to disturb the existing name.

This is a one-time bug, and I do think people are aware that ES3.1
is for 3430 only.

If we were to change this, how about "core_3xxxx_no_tll_sar_pwrdm"?
Or does anyone have a better name in mind?

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux