Hi, > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx > > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of > Taneja, Archit > > Sent: Wednesday, July 14, 2010 12:03 PM > > To: tomi.valkeinen@xxxxxxxxx > > Cc: linux-omap@xxxxxxxxxxxxxxx; Semwal, Sumit; Guruswamy, > > Senthilvadivu; Mittal, Mukund; Taneja, Archit; Nilofer, Samreen > > Subject: [RFC v2][PATCH 1/7] OMAP: DSS2: Overlay Manager > LCD2 changes > > in dispay.h > > > > From: Sumit Semwal <sumit.semwal@xxxxxx> > > > > Overlay Manager LCD2 changes in dispay.h > > > > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxx> > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx> > > Signed-off-by: Mukund Mittal <mmittal@xxxxxx> > > Signed-off-by: Archit Taneja <archit@xxxxxx> > > Signed-off-by: Samreen <samreen@xxxxxx> > > --- > > [sp] Do these changes really have to be in a separate patch? > Wouldn't it be better to combine them logically with > the usage? > > ~sanjeev > The introduction of the secondary channel causes many changes across different files, patches 1, 2, 4, 5, 7 introduces this feature and splits it both logically and on the basis of files modified. One of the main reason to introduce one single patch for display.h is because it is central to DSS2 and one glance at it tells how the other files will be affected. For example, if in a future patch we need to introduce another video pipeline, the file display.h will introduce the new enum member. Thanks, Archit-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html