>>-----Original Message-----
>>From: Menon, Nishanth
>>Sent: Tuesday, July 13, 2010 5:53 PM
>>To: Gopinath, Thara
>>Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxxxxxxxxxxxxxxx; paul@xxxxxxxxx; tony@xxxxxxxxxxx;
>>Cousson, Benoit; Sawant, Anand; Sripathy, Vishwanath; Premi, Sanjeev
>>Subject: Re: [PM-OPP][PATCH 2/4] OMAP: Correct the return value check after call into find_device_opp
>>
>>Gopinath, Thara had written, on 07/13/2010 12:47 AM, the following:
>>> Earlier we were checking on !dev_opp where as find_device_opp returns
>>> a error pointer in case of error. So correcting the check as in the earlier
>>> code even if find_device_opp returns an error opp_init_cpufreq_table
>>> was not exiting.
>>>
>>> Signed-off-by: Thara Gopinath <thara@xxxxxx>
>>> ---
>>> arch/arm/plat-omap/opp.c | 4 +++-
>>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
>>> index a06b88d..d88a2e0 100644
>>> --- a/arch/arm/plat-omap/opp.c
>>> +++ b/arch/arm/plat-omap/opp.c
>>> @@ -457,8 +457,10 @@ void opp_init_cpufreq_table(struct device *dev,
>>> int i = 0;
>>>
>>> dev_opp = find_device_opp(dev);
>>> - if (WARN_ON(!dev_opp))
>>> + if (IS_ERR(dev_opp)) {
>>> + WARN_ON(1);
>>could we use pr_warning here instead of WARN_ON?
The WARN_ON was already in the code. Added by you or Kevin. I just corrected the error checking.
Regards
Thara
>>
>>> return;
>>> + }
>>>
>>> freq_table = kzalloc(sizeof(struct cpufreq_frequency_table) *
>>> (dev_opp->enabled_opp_count + 1), GFP_ATOMIC);
>>
>>
>>--
>>Regards,
>>Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
