On Mon, 12 Jul 2010, Linus Torvalds wrote: > On Mon, Jul 12, 2010 at 12:17 PM, Nicolas Pitre <nico@xxxxxxxxxxx> wrote: > >> > >> Put another way: I realize that fairly late in the -rc series is > >> actually a really good time to do this, rather than during the merge > >> window itself when things are in flux. However, while it would be a > >> good time to pull this for that reason, it's also a _horrible_ time to > >> pull if it then regresses the defconfig uses, or if it causes horrible > >> problems for linux-next merging etc. > > > > This cannot be any worse than wholesale removal of those files as you > > were contemplating at some point. Furthermore, on ARM we have someone > > providing automatic rebuild of all defconfigs already, so any serious > > issue should be noticed right away. > > You aren't really answering the question. The thing is, the wholesale > removal wouldn't happen during the late -rc anyway, and it wouldn't > cause any merge issues (merge conflicts where the file is just to be > removed are trivial to take care of). I'll answer for myself only. Others are free to pitch in if they have a different opinion. Since this issue came up, RMK refused to merge any changes to the arch/arm/configs directory. Therefore a lot of those files aren't quite up to date anymore anyway. We simply skipped the usual defconfig updates that used to be sent around -rc4. And that's for the few defconfig files that people cared to update. A bunch of less frequently used targets are probably out of date since many kernel versions ago. Those files are mainly used as a convenience for build testing. We tend to cram as many profiles together as we can to limit the number of different test builds. The remaining files are (supposed to be) incompatible configurations. So I doubt anyone is using them verbatim for deployed systems. If anything they should be reference configurations not final product ones. > So I'm really asking about the issue of "how does this work during the > late -rc phase". Where the _timing_ is the important thing. Given what I said above, I think that: 1) Those files aren't critical. They're damn useful indeed, but a glitch in a defconfig file is far from being as important as a glitch in the very code they refer to. So I don't think this is all that critical if the pull is applied late in the -rc period. 2) Doing it sooner rather than later is IMHO the best thing to do. At least we could now focus on maintaining and even improving on that state rather than going on in circles wondering what to do with it. People would be able to think about how to update their defconfig files in the new form now instead of simply not updating it at all as it has been the case for a while until something happens. So to me this is all in favor for a merge before next merge window. During the merge window this would create even more headaches. > So when I ask about timing and "how does this work in late -rc", it's > really about how safe it is to do now. Because if it isn't very > obviously safe, I can't pull it. As I said above, those files aren't that critical and no one should end up in trouble if something is not exactly right after this merge. So this makes it pretty safe to me. > One part of the "obviously safe" thing is verification for each > defconfig file that the end result is identical with the reduced > version. Uwe implied that it was, and that was clearly the intention, > but was there some explicit verification that yes, the > before-and-after configurations are 100% the same? I'll let Uwe answer this. > Also, I assume that while it's _mostly_ a transparent change to users, > it does require that people do "make oldconfig" with the reduced > defconfig file first, in order to avoid having to answer with the > defaults. No? And the reduced defconfig files obviously do depend on > the default in the Kconfig files themselves, so it does have that kind > of fairly subtle semantic change that may not be entirely obvious or > easy to notice. That is going to be the case regardless of the merge timing for this. > So from a timing standpoint, I just want to be convinced that "late > -rc" really is the right thing. I'm not entirely sure it is, even > though I do see advantages. I do too. At least this is positive progress for some bad issue that no one could ever get very passionate about. Better keep the momentum. > > I think Uwe could provide his script and add it to the kernel tree. > > Then all architectures could benefit from it. Having the defconfig > > files contain only those options which are different from the defaults > > is certainly more readable, even on x86. > > Quite possible. But maintainers would need to be on the lookout of > people actually using the script, and refusing to apply patches that > re-introduce the whole big thing. Pretty easy to see on the diffstat graph. Anyway, I'm sure once the script is available then an army of kernel janitors will be busy trying to find any transgressor. > I also haven't actually seen the script - I don't think Uwe ever > posted it - so maybe it's some very fragile thing. Hard to judge on no > real information ;^p I'm sure the script was quickly cobbled together as a proof of concept. But once this defconfig reduction goes in then interest for a solid script should raise significantly. Nicolas
