On Mon, 12 Jul 2010, Artem Bityutskiy wrote: > From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> > > Do not forget to check the 'platform_device_add_data()' error code > in 'omap_device_build_ss()'. Looks fine to me, platform_device_add_data() can return -ENOMEM in the unlikely event that its kmemdup() fails. Acked-by: Paul Walmsley <paul@xxxxxxxxx> > > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> > Acked-by: Nishanth Menon <nm@xxxxxx> > --- > arch/arm/plat-omap/omap_device.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c > index ea0d659..d2b1609 100644 > --- a/arch/arm/plat-omap/omap_device.c > +++ b/arch/arm/plat-omap/omap_device.c > @@ -407,7 +407,9 @@ struct omap_device *omap_device_build_ss(const char *pdev_name, int pdev_id, > od->pdev.num_resources = res_count; > od->pdev.resource = res; > > - platform_device_add_data(&od->pdev, pdata, pdata_len); > + ret = platform_device_add_data(&od->pdev, pdata, pdata_len); > + if (ret) > + goto odbs_exit4; > > od->pm_lats = pm_lats; > od->pm_lats_cnt = pm_lats_cnt; > -- > 1.7.1.1 > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
