On Fri, 2010-06-25 at 16:46 -0500, Nishanth Menon wrote: > Add unlikely checks to better optimize the rare occurrance of > erroneous conditions. > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > Cc: Thara Gopinath <thara@xxxxxx> > > Signed-off-by: Nishanth Menon <nm@xxxxxx> unlikely and friends make sens only in realy hot path places. In other places like you touch, they are pointless - better let gcc make a choice of how to arrange code. And they only make the code less readable by adding extra braces and making ifs longer. Thus, NACK for this from my side. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
