Re: [PATCH 3/9 v3] omap: generic: introduce a single check_revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Menon, Nishanth <nm@xxxxxx> [100708 14:49]:
> 
> ----- Original message -----
> > Hi,
> > 
> > On Wed, Jul 07, 2010 at 07:24:16PM +0200, ext Nishanth Menon wrote:
> > > I am not sure.. if you would like drivers to be modprobabe, there may
> > be
> > > quirks that you'd want to enable based on cpu_is_omapxxx checks. so it
> > > probably does not make sense to __initdata the revision/feature
> > variables.
> > 
> > can't you pass the quirks via pdata, then ?
> 
> If pdata is passed based on board: Imagine 3630 and uart quirk. Why share errata xyz over pdata for every board using 3630? Quirks are cpu specific and not really domain of board..  

We should be able to handle the quirks by passing some
flag or function pointer from platform data.

The drivers should be arch independent, using cpu_is_omapxxxx
tests anywhere under drivers/* is wrong and should be
fixed.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux