Thanks Santosh, I have responded to your feedback. > > +#include <plat/hwspinlock.h> > > + > No need of new line here. > > +#include <plat/omap_device.h> > > +#include <plat/omap_hwmod.h> Alright I will fix that. > > +/* Initialization function */ > > +int __init hwspinlocks_init(void) > Since it's only init, can this go to "arch/arm/mach-omap2/omap4-commin.c" ? No, since it uses local #defines, we would prefer to put it in its own file. > > + if (retval == HWSPINLOCK_BUSY) > > + pm_runtime_put(&handle->pdev->dev); > What resource is getting release with above ?? That was a mistake actually. It should not be called because the device will be locked by the time that code is reached. Simon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
