Re: PATCH[V2 1/3]: Update Platform files for SPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Feb 18, 2010 at 11:29 AM, Grant Likely
> <grant.likely@xxxxxxxxxxxx> wrote:
>> On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>>> * Grant Likely <grant.likely@xxxxxxxxxxxx> [100218 08:26]:
>>>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>>>> > * Hemanth V <hemanthv@xxxxxx> [100203 02:19]:
>>>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>>>> >> From: Hemanth V <hemanthv@xxxxxx>
>>>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>>>> >> Subject: [PATCH] Update platform files
>>>> >>
>>>> >> This patch updates platform files for
>>>> >> fifo, slave support
>>>> >>
>>>> >> Signed-off-by: Hemanth V <hemanthv@xxxxxx>
>>>> >
>>>> > This should get merged via the spi-devel list with the other patches.
>>>> >
>>>> > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
>>>>
>>>> Tony, do you want me to add your acked-by to patches 2 & 3?
>>>
>>> No thanks, I've only looked at them briefly.
>>
>> Okay, thanks.
>>
>> Hemanth, I'm going to drop this series for the moment.  I'd like to
>> see some feedback/acks from current users and maintainers of the
>> omap2_mcspi driver before I merge support, especially now when the
>> merge window is about to open and it hasn't gotten any linux-next
>> exposure.
>>
>>>> Also, what is your feeling about patch 3/3, spi slave support.  spi
>>>> slave usage model is still a matter under debate, but that patch
>>>> doesn't touch core spi code, so I'm okay to merge it as a
>>>> driver-specific feature.  However, I'm not convinced that it is
>>>> actually a useful patch to merge yet, so I'll defer to you on this
>>>> one.  Thoughts?
>>>
>>> Up to you to decide. But here's my experience so far..
>>>
>>> Based on my experience if temporary hacks are merged, then nobody
>>> bothers to clean them up properly afterwards and the clean-up task
>>> unfairly falls on the maintainer.
>>>
>>> So IMHO, hacks like that are better floating on the mailing list
>>> until they're properly done. It's best to concentrate on getting
>>> the core things done right to make long term support easier.
>>
>> Right, I agree.  I'll ignore patch 3 entirely until I at least see a
>> patch for an in-tree user.
>
> Hi Hemanth.  Could you please respin patches 1 and 2 against
> 2.6.35-rc3?  The current patches do not apply anymore.
>

Grant,

Govindraj marked in this mail would rebase the patches and post the
same.

Thanks
Hemanth


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux