Hi, On Thu, 24 Jun 2010, Kevin Hilman wrote: > The omap_hwmod struct has a field to track the omap_device that is > attached to it, but it was not being assigned. Fix by assigning omap_device > pointer when omap_device is built. > > Cc: Paul Walmsley <paul@xxxxxxxxx> > Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> Just FYI, this patch has been converted to use an array index instead of pointer arithmetic - edited patch below. - Paul OMAP: omap_device: ensure hwmod tracks attached omap_device pointer From: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> The omap_hwmod struct has a field to track the omap_device that is attached to it, but it was not being assigned. Fix by assigning omap_device pointer when omap_device is built. Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [paul@xxxxxxxxx: use an array index rather than pointer arithmetic] Signed-off-by: Paul Walmsley <paul@xxxxxxxxx> --- arch/arm/plat-omap/omap_device.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index f899603..f9dec0d 100644 --- a/arch/arm/plat-omap/omap_device.c +++ b/arch/arm/plat-omap/omap_device.c @@ -359,7 +359,7 @@ struct omap_device *omap_device_build_ss(const char *pdev_name, int pdev_id, struct omap_device *od; char *pdev_name2; struct resource *res = NULL; - int res_count; + int i, res_count; struct omap_hwmod **hwmods; if (!ohs || oh_cnt == 0 || !pdev_name) @@ -416,6 +416,9 @@ struct omap_device *omap_device_build_ss(const char *pdev_name, int pdev_id, else ret = omap_device_register(od); + for (i = 0; i < oh_cnt; i++) + hwmods[i]->od = od; + if (ret) goto odbs_exit4; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
