RE: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomi,

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx]
> Sent: Wednesday, June 30, 2010 3:41 AM
> To: Aguirre, Sergio
> Cc: linux-omap@xxxxxxxxxxxxxxx; Tony Lindgren; Koen Kooi
> Subject: Re: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset
> gpio handling
> 
> On Tue, 2010-06-29 at 22:32 +0200, ext Sergio Aguirre wrote:
> > Following commit missed to remove this:
> >
> >   commit 044d32ffbcb4a1d400088e3575508f46c0a9face
> >   Author: Koen Kooi <koen.kooi@xxxxxxxxx>
> >   Date:   Thu Apr 22 10:23:42 2010 +0200
> >
> >       board-omap3-beagle: add DSS2 support
> >
> > Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> > Cc: Koen Kooi <koen.kooi@xxxxxxxxx>
> > ---
> >  arch/arm/mach-omap2/board-omap3beagle.c |    7 ++-----
> >  1 files changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-
> omap2/board-omap3beagle.c
> > index 7b95cc1..867a4ad 100644
> > --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> > @@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
> >  {
> >  	int r;
> >
> > +	omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
> 
> It's a reset gpio (actually power up/down, if I recall right), it should
> be configured as output, shouldn't it?

You're probably right :)

I just shuffled around the same code, which I guessed that works already. (right beagleboard guys?).

Regards,
Sergio

> 
>  Tomi
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux