RE: Boot fail on OMAP3430SDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aguirre, Sergio wrote:
> Sripathy, Vishwanath wrote:
> > Here is the log from Early printk.
> > 
> 
> <snip>
> 
> > Could not get gpios_ick
> > Could not get gpios_fck
> 
> Probably Tony will be the best to answer this, but... This 
> code shouldn't get executed I think (the one producing above prints)..
> 
> Above clocks are declared for omap2 only (in arch/arm/mach-omap2/clock24[20,30]_data.c), and even this 
> clk_get calls are inside of a supposedly omap2 only execution in arch/arm/plat-omap/gpio.c:
> 
> static int __init _omap_gpio_init(void)
> {
> ...
> ...
> #if defined(CONFIG_ARCH_OMAP2)
> 	if (cpu_class_is_omap2()) {


Isn't cpu_class_is_omap2() valid for OMAP3 as well?

> 		gpio_ick = clk_get(NULL, "gpios_ick");
> 		if (IS_ERR(gpio_ick))
> 			printk("Could not get gpios_ick\n");
> 		else
> 			clk_enable(gpio_ick);
> 		gpio_fck = clk_get(NULL, "gpios_fck");
> 		if (IS_ERR(gpio_fck))
> 			printk("Could not get gpios_fck\n");
> 		else
> 			clk_enable(gpio_fck);
> 
> 		/*
> 		 * On 2430 & 3430 GPIO 5 uses CORE L4 ICLK
> 		 */
> #if defined(CONFIG_ARCH_OMAP2430)
> 		if (cpu_is_omap2430()) {
> 			gpio5_ick = clk_get(NULL, "gpio5_ick");
> 			if (IS_ERR(gpio5_ick))
> 				printk("Could not get gpio5_ick\n");
> 			else
> 				clk_enable(gpio5_ick);
> 			gpio5_fck = clk_get(NULL, "gpio5_fck");
> 			if (IS_ERR(gpio5_fck))
> 				printk("Could not get gpio5_fck\n");
> 			else
> 				clk_enable(gpio5_fck);
> 		}
> #endif
> 	}
> #endif
> ...
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux