RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 Hello,

>-----Original Message-----
>From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] 
>Sent: Tuesday, June 29, 2010 4:35 PM
>To: Kalliguddi, Hema
>Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; 
>Felipe Balbi; tony@xxxxxxxxxxx
>Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
>omap_device_build for device registration.
>
>Hello.
>
>Hema HK wrote:
>
>> From: Hema HK  <hemahk@xxxxxx>
>
>    I think the patch description has clarity issues...
>
>> Changed the musb driver to use omap_build_device api instead of 
>
>    I don't see where are you changing the MUSB driver.

There is function name mismatch in the description.it should be "omap_device_build" instead of omap_build_device.
The change is in usb-musb.c file. I agree that it is not a driver file.I will change the description appropriately.

>
>> platform_device_registration.
>
>    Why underscores here?
>
I intended to provide the API name here platform_device_register. I will correct it.

>> The device specific resources defined in 
>> centralized database will be used. So removed the resource 
>definitions from
>> the driver file.
>
>    Do you mean usb-musb.c here? This is certainly not a driver.
>
Agreed not a driver.

Regards,
Hema
>> Signed-off-by: Hema HK <hemahk@xxxxxx>
>> Cc: Felipe Balbi <felipe.balbi@xxxxxxxxx>,tony@xxxxxxxxxxx
>
>WBR, Sergei
>
>--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux