RE: [PATCH] Add OMAP4 Panda Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Gadiyar, Anand
> Sent: Thursday, June 24, 2010 8:29 PM
> To: Anders, David; linux-omap@xxxxxxxxxxxxxxx
> Cc: tony@xxxxxxxxxxx
> Subject: RE: [PATCH] Add OMAP4 Panda Support
> 
> > +static void __init omap4_panda_init(void)
> > +{
> > +	int status;
> > +
> > +	omap4_panda_i2c_init();
> > +	omap_serial_init();
> > +	omap4_twl6030_hsmmc_init(mmc);
> > +	/* OMAP4 Panda uses internal transceiver so register nop transceiver
> */
> > +	usb_nop_xceiv_register();
> > +	/* FIXME: allow multi-omap to boot until musb is updated for omap4
> */
> > +	if (!cpu_is_omap44xx())
> > +		usb_musb_init(&musb_board_data);
> > +}
> 
> Dave,
> 
> I think this should be resolved by now - the OMAP4 MUSB support went
> through linux-usb for .35-rc1. So it should be safe to call
> usb_musb_init() unconditionally.
> 
> (Not actually tested by me yet. I'll try and do this tomorrow).
> 
> 
> - Anand

Anand,

I've done a few tests and still have a few errors with unconditional calls to musb_init. I'd like for core support to go ahead and move forward with the patch as is. I did a quick check and didn't see any patches submitted to change these lines in the 4430sdp, and for now, I would like to mirror as much as possible the functionality in the machine files for the panda and 4430sdp.

Tony,
If there are no objections, can we get someone to signoff on this so we can get it in the window?

Thanks
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux