>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >Sent: Friday, June 25, 2010 8:49 PM > >Thara Gopinath <thara@xxxxxx> writes: > >> This patch removes the usage of vdd and sr id alltogether. >> This is achieved by introducing a separte voltage domain per >> VDD and hooking this up with the voltage and smartreflex >> internal info structure. Any user of voltage or smartreflex layer >> should call into omap_volt_domain_get to get the voltage >> domain handle and make use of this to call into the various >> exported API's. >> >> These changes should be part of V2 of the sr/voltage series >> instead of being a separate patch in itself. >> >> Signed-off-by: Thara Gopinath <thara@xxxxxx> > >[...] > >> -static struct omap_sr *_sr_lookup(int srid) >> +static struct omap_sr *_sr_lookup(struct omap_volt_domain >*volt_domain) >> { >> struct omap_sr *sr_info, *temp_sr_info; >> >> sr_info = NULL; >> list_for_each_entry(temp_sr_info, &sr_list, node) { >> - if (srid == temp_sr_info->srid) { >> + if (volt_domain == temp_sr_info->volt_domain) { >> sr_info = temp_sr_info; >> break; > >Do we still need an _sr_lookup() function? Isn't there a single SR >instance per voltage domain? Yep, it must be a one to one mapping. But you still need to get the smartreflex instance that belong to a certain voltage domain. A voltage domain does not know if it has a SR that can control it. Benoit Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
