>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Friday, June 25, 2010 4:55 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, Vishwanath; Sawant, Anand >>Subject: Re: [PATCH 0/8] OMAP3: Adding Smartreflex and Voltage driver support >> >>Thara Gopinath <thara@xxxxxx> writes: >> >>> This patch series introduces smartreflex and voltage driver support >>> for OMAP3430 and OMAP3630. SmartReflex modules do adaptive voltage >>> control for real-time voltage adjustments. >>> >>> Originally all the functionalities introduced in this patch >>> were present in arch/arm/mach-omap2/smartreflex.c file in Kevin's >>> pm tree. This patch series does a major rewrite of this file >>> and introduces a separate voltage driver. Major contributors >>> to the original driver are >> >>I just noticed that one thing missing from this series compared to what >>was in the previous PM branch is the disable/enable of SR in the idle >>path, so SR is not getting exercised during idle anymore in the current >>PM branch. >> >>Could you rememdy that please with another patch on top of this series >>(the new pm-sr branch?) >> >>Kevin Hello Kevin, This was intentional as there is not voltage scaling happening in the idle thread in pm-sr branch. Smartreflex needs to be disabled only if a voltage scaling is done during retention/off. I had submitted a patch for addressing this and removing all voltage refrences in pm34xx.c against origin/pm branch the link to which is below https://patchwork.kernel.org/patch/103086/ Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
