Hi Ohad, > -----Original Message----- > From: C.A, Subramaniam > Sent: Thursday, June 24, 2010 5:24 PM > To: C.A, Subramaniam; Ohad Ben-Cohen; Kanigeri, Hari; Gupta, Ramesh > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi Doyu; Ramirez Luna, Omar > Subject: RE: [PATCH 3/4] omap mailbox: remove mbox_configured scheme > > > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx > > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of C.A, > > Subramaniam > > Sent: Thursday, June 24, 2010 4:36 PM > > To: Ohad Ben-Cohen; Kanigeri, Hari > > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi Doyu; Ramirez Luna, Omar > > Subject: RE: [PATCH 3/4] omap mailbox: remove mbox_configured scheme > > > > > > > -----Original Message----- > > > From: linux-omap-owner@xxxxxxxxxxxxxxx > > > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Ohad > > Ben-Cohen > > > Sent: Thursday, June 24, 2010 3:23 PM > > > To: Kanigeri, Hari > > > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi Doyu; Ramirez Luna, Omar > > > Subject: Re: [PATCH 3/4] omap mailbox: remove > mbox_configured scheme > > > > > > On Thu, Jun 24, 2010 at 6:10 PM, Kanigeri, Hari > > <h-kanigeri2@xxxxxx> > > > wrote: > > > > Ohad, > > > > > > > >> mbox_configured is global and therefore does not support > > > concurrent > > > >> usage of multiple mailbox instances. > > > > > > > > -- Why do you say that it doesn't support concurrent usage > > > of multiple mailbox instances ? If you take example of > > OMAP4, we have > > > 2 mailbox instances, one talking to DSP and other to Ducati > > and they > > > should be supported concurrently. > > > > > > > > > Interesting. was this actually tested and found working ? > > > > > I think by supporting multiple instances, what Hari meant was > > that, for DSP and Ducati 2 different struct omap_mbox * are > > returned. They still can maintain their own callback function > > (http://dev.omapzoom.org/?p=tisyslink/kernel-syslink.git;a=blo > > b;f=arch/arm/mach-omap2/mailbox.c;h=a23c7edf1e84ab4fa51e56d0c2 > > daf2922084751a;hb=438f7a6a3cced478eb121426201206f6205fbbdc#l32 > > 7 for Ducati and > > > > http://dev.omapzoom.org/?p=tisyslink/kernel-syslink.git;a=blob > > ;f=arch/arm/mach-omap2/mailbox.c;h=a23c7edf1e84ab4fa51e56d0c2d > > af2922084751a;hb=438f7a6a3cced478eb121426201206f6205fbbdc#l334 > > for DSP). > > > > The "mbox_configured" was a means to reference count for one > > instance of the struct omap_mbox * . > Sorry I that that back. Even though we maintain 2 strucutres, > only the one that calls the request_irq() is honoured. Hence > yes only one callback will be serviced (Thank to Ramesh for > pointing that out). Chaining of callbacks is a good way to > allow multiple clients to be notified. I agree, from your other mail[1], I agree on the option 2, which would provide support for multiple listeners for mailbox rx interrupt. [1] http://marc.info/?l=linux-omap&m=127741171610403&w=2 Thanks Ramesh Gupta G-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
