> >> then you add another ifdef to this file, which is already insane. I'd > >> rather see you either keep the local variables and just fix what needs > >> to be fixed, > > >> or use musb->mregs directly. > > > This one seems to be a much better one. Copying the v-3 with this fix > below. > > I don't see how it's *much* better... As it doesn't require to create another variable and moreover within ugly #ifdefs of three different flavors (HOST, DEVCIE and OTG). I think it's better to kill all 'mbase' variables and use musb->mregs directly for a better code readability. -Ajay > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
