One correction here:
On Wed, 23 Jun 2010, Paul Walmsley wrote:
> On Mon, 21 Jun 2010, Kevin Hilman wrote:
>
> > Just to clarify. The functions I'm overriding here is the bus
> > functions (bus->pm->[suspend|resume]_noirq(), not any driver functions
>
> OK, I see that now - this code was confusing in the patch's
> platform_pm_suspend_noirq():
>
> + if (drv->pm) {
> + if (drv->pm->suspend_noirq)
> + ret = drv->pm->suspend_noirq(dev);
> + }
>
> This is already done by the DPM core in
> drivers/base/power/main.c:device_suspend_noirq() and will result in
> re-executing the driver's suspend_noirq function, which is potentially
> quite bad. Same thing for platform_pm_resume_noirq() in the patch.
Sorry, misread this also. Indeed, something like this is necessary in
your platform bus override code - so please ignore this part of the
comments.
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
