On Thu, Jun 17, 2010 at 7:45 AM, Felipe Balbi <felipe.balbi@xxxxxxxxx> wrote: > Hi, > > On Wed, Jun 16, 2010 at 07:26:30PM +0200, ext Grazvydas Ignotas wrote: >> So how is this supposed to be used here, should I request all GPIOs I >> want to have debouncing on, setup debounce time and release them for >> gpio-keys to take? Or should I wait for this to get supported in >> gpio-keys? > > to me it looks like the *_keys_gpio_init() function should be passed down to > gpio-keys as a ->setup() callback and you should probably also pass a > ->teardown() which would clear debounce time when you remove the driver. > Then only call those functions after gpio has been requested. gpio-keys platform data already has 'debounce_interval' member, which is used to setup timer (if nonzero) in the driver. So I maybe it would be better to modify gpio-keys to try to set debounce, and if that fails make it fall back to it's current timer-based debounce functionality? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
