RE: [PATCH v3 3/3] DSS2 FB Allow usage of def_vrfb only for omap2,3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tomi, 

> -----Original Message-----
> From: Guruswamy, Senthilvadivu 
> Sent: Thursday, June 10, 2010 4:54 PM
> To: linux-omap@xxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; 
> tony@xxxxxxxxxxx; tomi.valkeinen@xxxxxxxxx; Hiremath, Vaibhav
> Cc: Guruswamy, Senthilvadivu
> Subject: [PATCH v3 3/3] DSS2 FB Allow usage of def_vrfb only 
> for omap2,3
> 
> From: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> 
> Changes since v2:
> 	Added a check to warn the wrong usage of vrfb in 
> non-vrfb omap devices.
> 
> Force def_vrfb to 0 for non omap2, omap3 devices
> 
> Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> ---
>  drivers/video/omap2/omapfb/omapfb-main.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c 
> b/drivers/video/omap2/omapfb/omapfb-main.c
> index 4b4506d..0f79db8 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -2128,6 +2128,16 @@ static int omapfb_probe(struct 
> platform_device *pdev)
>  		goto err0;
>  	}
>  
> +	/* TODO : Replace cpu check with omap_has_vrfb once HAS_FEATURE
> +	*	 available for OMAP2 and OMAP3
> +	*/
> +	if (def_vrfb && (!cpu_is_omap24xx()) && (!cpu_is_omap34xx())) {
> +		def_vrfb = 0;
> +		dev_warn(&pdev->dev, "VRFB is not in this device,"
> +				"using DMA for rotation\n");
> +	}
> +
> +
>  	mutex_init(&fbdev->mtx);
>
[Senthil]  All the comments received are incorporated in this v3.
I don't see any more comments on this patch series.  Is it
fine for you to take up this series of patches?
>  	fbdev->dev = &pdev->dev;
> -- 
> 1.6.3.3
> 
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux