Re: [PATCH v5 0/3] omap3 nand: cleanup exiting platform related code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Vimal Singh <vimal.newwork@xxxxxxxxx>

On Fri, Jun 4, 2010 at 1:10 PM, Sukumar Ghorai <s-ghorai@xxxxxx> wrote:
>   The following set of patches applies on top of for-next branch.
>        http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git
>   Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board
>
>   And these are the patches required to address the following input -
>     1. The NAND driver needs to stop tinkering with the GPMC registers
>        The omap General Purpose Memory Controller (GPMC) registers are omap
>        specific, and not driver specific. Tinkering with these registers can
>        cause issues with the other devices on the GPMC.
>
>     2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
>        Passing hardcoded GPMC virtual addressess is sure way to mess up things.
>        This should all become unnecessary once the NAND drivers stops messing
>        with the GPMC registers directly.
>     Discussion: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg27630.html
>
>   Changes in this series -
>                Unused function removed.
>
>  Functions related to ecc and prefetch engine are optimized.
>  v4: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg29458.html
>
>  Few functionality was missing  like - There should be some locking as only
>   one chipselect can use the ECC or prefetch engine at a time. If you have
>   NAND in two chipselects, bad things would happen.
>  v3: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg28715.html
>
>  Additionally, it was needed to implement more functions for the platform
>  init code to use.
>  v2: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg28467.html
>
>  v1: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg28164.html
>
>
> Sukumar Ghorai (3):
>        omap3 gpmc: functionality enhancement
>        omap3 nand: cleanup virtual address usages
>        omap3 nand: fix issue in board file to detect nand
>  arch/arm/mach-omap2/board-cm-t35.c         |   20 +---
>  arch/arm/mach-omap2/board-devkit8000.c     |   25 +---
>  arch/arm/mach-omap2/board-omap3beagle.c    |   24 +---
>  arch/arm/mach-omap2/board-omap3touchbook.c |   25 +---
>  arch/arm/mach-omap2/board-overo.c          |   24 +---
>  arch/arm/mach-omap2/board-sdp-flash.c      |    5 -
>  arch/arm/mach-omap2/gpmc-nand.c            |   39 ++----
>  arch/arm/mach-omap2/gpmc.c                 |  228 +++++++++++++++++++++++++---
>  arch/arm/plat-omap/include/plat/gpmc.h     |   36 ++++-
>  arch/arm/plat-omap/include/plat/nand.h     |    6 +-
>  drivers/mtd/nand/omap2.c                   |  229 ++++++++--------------------
>  11 files changed, 320 insertions(+), 341 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Regards,
Vimal Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux