From: ext Felipe Contreras <felipe.contreras@xxxxxxxxx> Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 11:43:28 +0200 > On Tue, Jun 8, 2010 at 6:46 AM, Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> wrote: >> From: "ext Guzman Lugo, Fernando" <fernando.lugo@xxxxxx> >>> I think the best thing to do here is remove the spinlock, if not, >>> you are preventing that omap_mbox_msg_send be executed from a >>> tasklet or isr context. That maybe in this moment it is not called >>> but it could be needed in the future. The caller of >>> omap_mbox_msg_send should be take care of that function can not be >>> call simultaneously. >> >> What about adding another function, omap_mbox_msg_send_sync()? > > That's exactly what I was thinking about when I heard the problem. > Would this function send all the msgs already queued, and then wait > for the current one actually be sent? Could be as you said. I haven't thought that much. What I just thought was to bypass kfifo and tasklet and to put a message directly to H/W fifo. Maily just for the above case which Fernando described above. Fernando, what do you think on Felipes? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
