On Fri, Jun 4, 2010 at 9:05 PM, Kevin Hilman
<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
> "Govindraj.R" <govindraj.raja@xxxxxx> writes:
>
>> This patch makes the following:
>> - Adds missing wakeup padding register handling.
>> - Fixes a hardcode to use PER module ONLY on UART3.
>> - Muxmode usage needed for uart4 for 3630 for padconf
>> wakeup on rx line.
>
> The need for this muxmode needs to be better described.
>
> The usage of the new set muxmode function is not terribly clear.
> You're calling it in both _enable_wakeup() and _disable_wakeup() and
> in _resume_idle(), but it's not terribly clear (to me, or the casual
> changelog reader) why this is being done.
Intention was to ensure being in the right mux mode before accessing the
padconf reg. Since we have padconf usage in these function I have
mux mode configuration before accessing padconf reg.
Will update changelog accordingly.
>>
>> +static inline void omap_uart_setmux_mode(struct omap_uart_state *uart)
>
> How about _set_muxmode()
ok fine, will change to omap_uart_set_muxmode(
>
>> +{
>> + u16 w = omap_ctrl_readw(uart->padconf);
>
> insert blank line
Sure will do.
> } else if (cpu_is_omap24xx()) {
>> u32 wk_mask = 0;
>
> Kevin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Thanks,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
