> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, June 03, 2010 11:10 PM > To: Lesly A M > Cc: linux-omap@xxxxxxxxxxxxxxx; Lesly A M; Nishanth Menon; David Derrick; > Samuel Ortiz > Subject: Re: [PATCH v6 2/7] omap3: pm: Using separate clk/volt setup_time > for RET and OFF states > > Lesly A M <leslyam@xxxxxx> writes: > > > This patch will have the changes to use separate clk/volt setup_time > > for RET and OFF state. > > > > Create separate copies of VC parameters for each Si in voltage.c. > > Updates the VC setuptime struct during init based on the OMAP Si. > > Removes the VC setuptime struct from board files. > > > > Signed-off-by: Lesly A M <x0080970@xxxxxx> > > Cc: Nishanth Menon <nm@xxxxxx> > > Cc: David Derrick <dderrick@xxxxxx> > > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > > OK, so you addressed one of my comments from the previous review[1], > but didn't address the others, so they have re-appeared in this > series, only in different patches this time. :( > Sorry, I missed the comment... > > > diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach- > omap2/voltage.h > > index c6445c5..cc2b355 100644 > > --- a/arch/arm/mach-omap2/voltage.h > > +++ b/arch/arm/mach-omap2/voltage.h > > @@ -14,6 +14,31 @@ > > #define VDD1 0 > > #define VDD2 1 > > > > +struct setuptime_vc{ > > + u16 clksetup; > > + u16 voltsetup1_vdd1; > > + u16 voltsetup1_vdd2; > > + u16 voltsetup2; > > + u16 voltoffset; > > +}; > > + > > +struct prm_setup_vc { > > +/* CLK & VOLT SETUPTIME for RET */ > > + struct setuptime_vc ret; > > +/* CLK & VOLT SETUPTIME for OFF */ > > + struct setuptime_vc off; > > +/* PRM_VC_CMD_VAL_0 specific bits */ > > + u16 vdd0_on; > > + u16 vdd0_onlp; > > + u16 vdd0_ret; > > + u16 vdd0_off; > > +/* PRM_VC_CMD_VAL_1 specific bits */ > > + u16 vdd1_on; > > + u16 vdd1_onlp; > > + u16 vdd1_ret; > > + u16 vdd1_off; > > +}; > > + > > Copy-paste from previous review[1]: > > Minor nit (and not your fault since you inherited it): > > Please indent the comments to the same level as the code. > > Kevin > > > [1] http://marc.info/?l=linux-omap&m=127249508726287&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
