Re: [PATCH v3 00/14] omap: mailbox: bunch of cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 3, 2010 at 2:47 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Thu, Jun 03, 2010 at 09:40:22AM +0300, Hiroshi DOYU wrote:
>> > Felipe Contreras (14):
>> >   omap: mailbox: trivial whitespace cleanups
>> >   omap: mailbox: trivial cleanups
>
> I think folk need to read this:
>
>        http://lkml.org/lkml/2010/6/2/472
>
> and consider what it means for the future, and what can be done to reduce
> the amount of "churn".

If I have to decipher that rant, my best guess is that he is
complaining about the amount of code. If that's the case, this patch
series is only doing good:
6 files changed, 168 insertions(+), 230 deletions(-)

Another part of the rant is the fact that Linus cannot follow the huge
amount of changes. I think "trivial whitespace cleanups" pretty much
says: don't look at me if you want to be productive, while "trivial
cleanups" says, look at me if you feel like looking at easy changes.
If I were to squash these two, I think the patch series would become
harder to follow.

Something that helps in other projects, like git, is that merges are
clearly identified.

Merge branch 'linux-arm'
 Merge branch 'linux-omap'
  Merge branch 'linux-omap-mbox'
   Merge branch 'fc-cleanups'
   Merge branch 'ob-kfifo'

Then it's a bit clearer what each patch series is doing in the mailbox
tree without looking at individual patches.

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux